[OUDS] Add "Grid" tokens, utilities, examples and documentation #2744

hannahiss · 2024-09-26T13:01:29Z

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Closes #2609

Description

Uncomment and restore documentation pages in Layout: Breakpoints, Containers, Grid, Columns, Utilities
Use new breakpoints for every utilities/helpers (grids, columns, gutters, display, flex, ...)
Use .container-fluid .max-width-specific-tools as container for the documentation website
Add new example page "grid-system" to test grids
Change mixin _assert-ascending to accept two identical values that follow each other

Not included:

Gutters should be treated with dimensions tokens PR [OUDS] Add "Dimension" tokens, utilities and documentation #2754 (as their values come from spacing). Doc should be reviewed to be more understandable for users
Bootstrap compatibility will be treated in PR [OUDS] Grid tokens Bootstrap compatibility (xxl breakpoint) #2761
CSS-Grid system should be updated to use the same gutter values than flexbox grid system in another PR

Motivation & Context

Types of change

Breaking change (fix or feature that would change existing functionality)

Live previews

Uncommented pages:

Modified pages:

New pages:

https://deploy-preview-2744--boosted.netlify.app/docs/examples/grid-system/

netlify · 2024-09-26T13:03:00Z

✅ Deploy Preview for boosted ready!

Name	Link
🔨 Latest commit	`132b455`
🔍 Latest deploy log	https://app.netlify.com/sites/boosted/deploys/671a42af2648fc0008f5a41b
😎 Deploy Preview	https://deploy-preview-2744--boosted.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

scss/tokens/_raw.scss

louismaximepiton

First batch of comments.
A fake example should be removed somewhere.

site/content/docs/0.0/layout/breakpoints.md

scss/mixins/_grid.scss

scss/_containers.scss

site/content/docs/0.0/layout/containers.md

site/content/docs/0.0/layout/columns.md

site/content/docs/0.0/examples/grid/index.html

site/content/docs/0.0/migration-from-boosted.md

louismaximepiton

Second batch, missing the 4 documentation files, 1 example and migration guides

scss/_variables.scss

scss/mixins/_grid.scss

site/content/docs/0.0/examples/grid-system/grid-system.css

site/content/docs/0.0/examples/grid-system/index.html

scss/_containers.scss

site/assets/scss/_layout.scss

louismaximepiton

I'll review the migration guides once all the above are considered as done.

site/assets/scss/_layout.scss

site/assets/scss/_scrolling.scss

site/content/docs/0.0/examples/grid/index.html

site/static/docs/0.0/assets/img/examples/grid-system.png

site/content/docs/0.0/layout/breakpoints.md

site/content/docs/0.0/layout/grid.md

louismaximepiton

Just pinging for few comments that can be resolved in my opinion. I'm reviewing the migration guides in the meantime. Great work, GG 🚀

site/content/docs/0.0/examples/grid-system/index.html

site/content/docs/0.0/layout/columns.md

scss/_variables.scss

site/content/docs/0.0/layout/breakpoints.md

scss/_containers.scss

site/content/docs/0.0/examples/grid-system/index.html

site/content/docs/0.0/examples/grid/index.html

site/content/docs/0.0/helpers/stretched-link.md

site/content/docs/0.0/layout/grid.md

scss/_containers.scss

scss/_maps.scss

site/content/docs/0.0/utilities/api.md

site/content/docs/0.0/migration.md

site/data/examples.yml

site/layouts/partials/footer.html

site/content/docs/0.0/utilities/api.md

hannahiss changed the base branch from main to ouds/main September 26, 2024 13:02

julien-deramond changed the title ~~Add "Grid" tokens, utilities, examples and documentation~~ [OUDS] Add "Grid" tokens, utilities, examples and documentation Sep 26, 2024

julien-deramond added this to the OUDS milestone Sep 26, 2024

julien-deramond added the feature label Sep 26, 2024

julien-deramond linked an issue Sep 26, 2024 that may be closed by this pull request

[OUDS] Tokens: Grid #2609

Closed

1 task

julien-deramond reviewed Sep 30, 2024

View reviewed changes

scss/tokens/_raw.scss Outdated Show resolved Hide resolved

This comment was marked as resolved.

Sign in to view

louismaximepiton mentioned this pull request Oct 7, 2024

[OUDS] Add "Dimension" tokens, utilities and documentation #2754

Merged

5 tasks

This comment was marked as resolved.

Sign in to view

louismaximepiton requested changes Oct 9, 2024

View reviewed changes

louismaximepiton reviewed Oct 10, 2024

View reviewed changes

hannahiss marked this pull request as ready for review October 11, 2024 07:21

louismaximepiton reviewed Oct 11, 2024

View reviewed changes

louismaximepiton reviewed Oct 15, 2024

View reviewed changes

site/content/docs/0.0/examples/grid-system/index.html Outdated Show resolved Hide resolved

site/content/docs/0.0/layout/columns.md Outdated Show resolved Hide resolved

scss/_variables.scss Outdated Show resolved Hide resolved

site/content/docs/0.0/layout/breakpoints.md Show resolved Hide resolved